[SourceKit] Link with libdispatch & libswiftCore on Linux #3594
Conversation
sourcekitdInProc, sourcekitd-test, and complete-test need to be explicitly linked with libdispatch on Linux to build properly.
This file builds fine as long as libdispatch is available, even on non-Darwin platforms.
since libdispatch now includes a Swift overlay
jpsim
force-pushed
the
sourcekit-link-libdispatch
branch
from
2d9e563
to
d3d211b
Compare
|
@swift-ci Please test |
|
@akyrtzi btw, I think you may need to re-trigger CI, since the last request was done during the CI maintenance window, whereas later requests have already started (#3616 (comment)). |
|
@swift-ci Please test |
|
Please join me in a fire dance to get CI to run 😂 |
|
Sounds like fun! @swift-ci please test |
|
OS X failure is unrelated. |
|
Thanks @akyrtzi! |
since swiftlang/swift#3594 & swiftlang/swift#3595 were recently merged, we can build SourceKit without any patches to Swift! 🎉
|
FYI, SourceKit now builds successfully on Linux 🎉 (in two steps): |
ghost
mentioned this pull request
|
@jpsim what's blocking it to being available by default in the toolchain? |
|
Swift needs to be built twice for SourceKit to compile successfully, because libdispatch depends on Swift for its overlay, and SourceKit depends on libdispatch. There's some build system refactoring needed to build SourceKit as part of a single, normal Swift build. This is being tracked as SR-1676 which is unassigned and up for grabs if you're interested in tackling this @paulofaria. |
|
Could you please look at http://stackoverflow.com/questions/39941523/building-swift-sourcekit-on-linux? |
What's in this pull request?
This PR is exactly #2862, with some minor additional changes to account for the new libdispatch Swift overlay that was added since the original PR and so must now link
swiftCore.Everything else that was discussed in #2862 still applies here.
cc @akyrtzi @briancroom @modocache
All credit here goes to @briancroom @modocache and @norio-nomura, I just re-assembled the commits.
Resolved bug number: (SR-1677)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.